Fix 6 clippy warnings in AVX-512 microkernels#6
Merged
Conversation
- Remove useless `.into()` on u16/u8 mask args (already correct type) - Remove identity `+ 0` on array index offsets cargo clippy -- -D warnings now passes clean. https://claude.ai/code/session_01QnZH2adQ6oXzTYPkLTH6G7
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
AdaWorldAPI
pushed a commit
that referenced
this pull request
Mar 23, 2026
#1 VML wiring: Wire F32x16/F64x8 SIMD types into scalar VML loops - vsln: 16-wide via simd_ln_f32 - vdsqrt: 8-wide via F64x8::sqrt() - vdabs: 8-wide via F64x8::abs() - vssin/vscos: batch load/store via F32x16 (scalar per-lane, SIMD framework) - vspow: 16-wide via exp(b*ln(a)) using simd_exp_f32 + simd_ln_f32 - 7 new tests covering SIMD paths #5 columnar_view: Zero-copy Arrow interop - SoakingBuffer::as_columnar_slice() / as_columnar_slice_mut() - PlaneBuffer::as_binary_slice() - 3 new tests for zero-copy view correctness #6 simd_apply: Generic fused SIMD kernel - simd_apply(a, b, out, Fn(F32x16, F32x16) -> F32x16) - simd_apply_unary(x, out, Fn(F32x16) -> F32x16) - simd_apply_inplace(a, b, Fn(F32x16, F32x16) -> F32x16) - Proper tail handling via zero-padded SIMD - 6 new tests (add, FMA, sqrt, inplace, empty, tail-only) #10 prefetch: Explicit _mm_prefetch in cascade_query - prefetch_t0/t1 wrappers (x86_64 SSE, no-op elsewhere) - Stroke 1: prefetch PREFETCH_DISTANCE=4 candidates ahead (L1) - Stroke 2: prefetch next survivor's data (L2) - Stroke 3: prefetch next survivor's data (L1) All 51 targeted tests pass. Scorecard: 4/10 → 6/10 done. https://claude.ai/code/session_01CdqyUTUfjKZuk8YGJzv6LB
AdaWorldAPI
pushed a commit
that referenced
this pull request
Mar 30, 2026
Tactics 1-12 from the 34-tactic integration plan, adapted to ndarray: styles::rte — #1 Recursive Thought Expansion (Hofstadter) styles::htd — #2 Hierarchical Thought Decomposition (CLAM) styles::smad — #3 Structured Multi-Agent Debate (NARS revision) styles::tcp — #5 Thought Chain Pruning (Berry-Esseen) styles::irs — #9 Iterative Roleplay Synthesis (XOR binding) styles::mcp — #10 Meta-Cognition (Brier score calibration) styles::tca — #12 Temporal Context (Reichenbach tense) Plus additions to existing modules: causal_diff.rs — #4 reverse_trace() (Pearl Rung 3) bgz17_bridge.rs — #6 inject_noise() (simulated annealing) nars.rs — #7 adversarial_critique(), #11 detect_contradiction() cascade.rs — #8 adaptive_resolution() Every tactic is fn(Base17, NarsTruth) → result. No LLM prompting. 16 tests passing. API: crate::hpc::styles::rte::expand() etc. https://claude.ai/code/session_01M3at4EuHVvQ8S95mSnKgtK
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.into()on u16/u8 mask args (already correct type)+ 0on array index offsetscargo clippy -- -D warnings now passes clean.
https://claude.ai/code/session_01QnZH2adQ6oXzTYPkLTH6G7